samples: pmic: update npm1300_fuel_gauge sample to support nPM1304 #23437

seov-nordic · 2025-07-24T10:06:49Z

Added possibility to choose the nPM1300 or the nPM1304 EK shield to build for. Adapted code and DTS overlays to accomodate both PMICs.

NordicBuilder · 2025-07-24T10:11:12Z

CI Information

^{To view the history of this post, clich the 'edited' button above}
Build number: 24

Inputs:

Sources:

sdk-nrf: PR head: 486ccec75a65d6bd72abbdd1989915d3c7113c04

more details

sdk-nrf:

PR head: 486ccec75a65d6bd72abbdd1989915d3c7113c04
merge base: 3216ae0845705630ffab1e1b5738ecd43f5444cb
target head (main): 7f177c3c099679ecbd965ec8c6fe4766fb5ebc60
Diff

Github labels

Enabled	Name	Description
	ci-disabled	Disable the ci execution
	ci-all-test	Run all of ci, no test spec filtering will be done
	ci-force-downstream	Force execution of downstream even if twister fails
	ci-run-twister	Force run twister
	ci-run-zephyr-twister	Force run zephyr twister

List of changed files detected by CI (34)

doc
│  ├── _utils
│  │  │ redirects.py
│  ├── nrf
│  │  ├── app_dev
│  │  │  ├── device_guides
│  │  │  │  ├── pmic
│  │  │  │  │  │ npm1300.rst
│  │  ├── links.txt
│  │  ├── releases_and_maturity
│  │  │  ├── releases
│  │  │  │  ├── release-notes-2.4.0.rst
│  │  │  │  ├── release-notes-2.6.0.rst
│  │  │  │  ├── release-notes-2.8.0-preview1.rst
│  │  │  │  ├── release-notes-2.8.0.rst
│  │  │  │  ├── release-notes-3.0.0-preview1.rst
│  │  │  │  ├── release-notes-3.0.0-preview2.rst
│  │  │  │  ├── release-notes-3.0.0.rst
│  │  │  │  │ release-notes-3.1.0.rst
samples
│  ├── pmic
│  │  ├── native
│  │  │  ├── npm13xx_fuel_gauge
│  │  │  │  ├── CMakeLists.txt
│  │  │  │  ├── README.rst
│  │  │  │  ├── boards
│  │  │  │  │  ├── extensions
│  │  │  │  │  │  ├── nrf54h20dk
│  │  │  │  │  │  │  │ nrf54h20dk_nrf54h20_cpuapp.overlay
│  │  │  │  │  │  ├── nrf54l15dk
│  │  │  │  │  │  │  │ nrf54l15dk_nrf54l15_cpuapp.overlay
│  │  │  │  │  │  ├── nrf54lm20dk
│  │  │  │  │  │  │  │ nrf54lm20dk_nrf54lm20a_cpuapp.overlay
│  │  │  │  │  ├── nrf52840dk_nrf52840.overlay
│  │  │  │  │  ├── nrf52dk_nrf52832.overlay
│  │  │  │  │  ├── nrf5340dk_nrf5340_cpuapp.overlay
│  │  │  │  │  ├── nrf54h20dk_nrf54h20_cpuapp.overlay
│  │  │  │  │  ├── nrf54l15dk_nrf54l15_cpuapp.overlay
│  │  │  │  │  ├── nrf54lm20dk_nrf54lm20a_cpuapp.overlay
│  │  │  │  │  │ nrf9160dk_nrf9160.overlay
│  │  │  │  ├── npm1300.overlay
│  │  │  │  ├── npm1304.overlay
│  │  │  │  ├── prj.conf
│  │  │  │  ├── sample.yaml
│  │  │  │  ├── src
│  │  │  │  │  ├── CMakeLists.txt
│  │  │  │  │  ├── battery_model.inc
│  │  │  │  │  ├── battery_model_20mAh.inc
│  │  │  │  │  ├── fuel_gauge.c
│  │  │  │  │  ├── fuel_gauge.h
│  │  │  │  │  │ main.c
scripts
│  │ quarantine_integration.yaml

Outputs:

Toolchain

Version: c5be9c56c7
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:c5be9c56c7_bba2ea5f2e

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

◻️ Toolchain - Skipped: existing toolchain is used
✅ Build twister
- sdk-nrf test count: 19
✅ Integration tests

Disabled integration tests

- test-fw-nrfconnect-nrf_lrcs_mosh
- test-fw-nrfconnect-nrf_lrcs_positioning
- desktop52_verification
- doc-internal
- test_ble_nrf_config
- test-fw-nrfconnect-apps
- test-fw-nrfconnect-ble_mesh
- test-fw-nrfconnect-ble_samples
- test-fw-nrfconnect-chip
- test-fw-nrfconnect-fem
- test-fw-nrfconnect-nfc
- test-fw-nrfconnect-nrf-iot_cloud
- test-fw-nrfconnect-nrf-iot_libmodem-nrf
- test-fw-nrfconnect-nrf-iot_lwm2m
- test-fw-nrfconnect-nrf-iot_samples
- test-fw-nrfconnect-nrf-iot_serial_lte_modem
- test-fw-nrfconnect-nrf-iot_thingy91
- test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
- test-fw-nrfconnect-nrf_crypto
- test-fw-nrfconnect-proprietary_esb
- test-fw-nrfconnect-ps-main
- test-fw-nrfconnect-rpc
- test-fw-nrfconnect-rs
- test-fw-nrfconnect-tfm
- test-fw-nrfconnect-thread-main
- test-low-level
- test-sdk-audio
- test-sdk-dfu
- test-sdk-find-my
- test-sdk-mcuboot
- test-sdk-pmic-samples
- test-sdk-wifi
- test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

github-actions · 2025-07-24T13:12:35Z

Since quarantine was modified, please make sure you are following the process described in Quarantine Process.

github-actions · 2025-07-24T13:37:16Z

You can find the documentation preview for this PR here.

Preview links for modified nRF Connect SDK documents:

samples/pmic/native/npm13xx_fuel_gauge/sysbuild/CMakeLists.txt

samples/pmic/native/npm13xx_fuel_gauge/src/fuel_gauge.c

samples/pmic/native/npm13xx_fuel_gauge/sample.yaml

samples/pmic/native/npm13xx_fuel_gauge/README.rst

doc/nrf/releases_and_maturity/releases/release-notes-2.4.0.rst

doc/nrf/releases_and_maturity/releases/release-notes-2.6.0.rst

doc/nrf/releases_and_maturity/releases/release-notes-2.8.0-preview1.rst

doc/nrf/releases_and_maturity/releases/release-notes-2.8.0.rst

doc/nrf/releases_and_maturity/releases/release-notes-3.0.0-preview1.rst

doc/nrf/releases_and_maturity/releases/release-notes-3.0.0-preview2.rst

doc/nrf/releases_and_maturity/releases/release-notes-3.0.0.rst

samples/pmic/native/npm13xx_fuel_gauge/README.rst

seov-nordic · 2025-07-30T08:10:56Z

@peknis the compliance check is failing with the nPM1304 product website URL (https://www.nordicsemi.com/products/npm1304). It is valid though, I re-ran the check and it still fails with 403. Anything I can do?

peknis · 2025-07-30T08:19:10Z

@peknis the compliance check is failing with the nPM1304 product website URL (https://www.nordicsemi.com/products/npm1304). It is valid though, I re-ran the check and it still fails with 403. Anything I can do?

Very weird, it seems, indeed, that you have added the link target to the links.txt and your link in the doc seems valid. Trying to have another pair of eyes checking why this fails.

seov-nordic · 2025-07-31T08:10:53Z

@nordicjm please take a look at the replies

samples/pmic/native/npm13xx_fuel_gauge/README.rst

doc/nrf/releases_and_maturity/releases/release-notes-2.4.0.rst

doc/nrf/releases_and_maturity/releases/release-notes-2.6.0.rst

doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst

samples/pmic/native/npm13xx_fuel_gauge/README.rst

doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst

divipillai · 2025-08-07T09:20:01Z

The link of the compliance failure works as expected, when accessed and from doc preview page as well. The CI-rerun or rebase might fix the compliance error.

seov-nordic · 2025-08-19T09:08:10Z

@nordicjm could we please move forward with this? See my replies to the review comments and suggest changes if needed

Added possibility to choose the nPM1300 or the nPM1304 EK shield to build for. Adapted code and DTS overlays to accomodate both PMICs. Signed-off-by: Sergei Ovchinnikov <[email protected]>

seov-nordic added this to the 3.1.0 milestone Jul 24, 2025

github-actions bot added doc-required PR must not be merged without tech writer approval. changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Jul 24, 2025

seov-nordic force-pushed the npm1304-sample-support branch 4 times, most recently from 24f63d0 to 5bdaba9 Compare July 24, 2025 13:12

seov-nordic force-pushed the npm1304-sample-support branch from 5bdaba9 to 805c3aa Compare July 24, 2025 14:10

github-actions bot removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Jul 24, 2025

seov-nordic force-pushed the npm1304-sample-support branch 2 times, most recently from 978fa25 to 5defad1 Compare July 25, 2025 10:45

nordic-auko reviewed Jul 28, 2025

View reviewed changes

seov-nordic force-pushed the npm1304-sample-support branch 3 times, most recently from 613c364 to 650da9d Compare July 30, 2025 07:36

seov-nordic marked this pull request as ready for review July 30, 2025 07:37

seov-nordic requested review from a team as code owners July 30, 2025 07:37

nordic-piks approved these changes Jul 30, 2025

View reviewed changes

peknis requested changes Jul 30, 2025

View reviewed changes

samples/pmic/native/npm13xx_fuel_gauge/README.rst Outdated Show resolved Hide resolved

seov-nordic requested a review from nordicjm July 30, 2025 11:21

seov-nordic force-pushed the npm1304-sample-support branch from e128b21 to efcef1c Compare August 1, 2025 06:53

richabp approved these changes Aug 1, 2025

View reviewed changes

greg-fer requested changes Aug 1, 2025

View reviewed changes

seov-nordic force-pushed the npm1304-sample-support branch from efcef1c to 7bd825e Compare August 4, 2025 07:10

seov-nordic requested a review from greg-fer August 4, 2025 07:11

divipillai reviewed Aug 4, 2025

View reviewed changes

doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst Outdated Show resolved Hide resolved

greg-fer approved these changes Aug 5, 2025

View reviewed changes

seov-nordic removed this from the 3.1.0 milestone Aug 7, 2025

divipillai approved these changes Aug 7, 2025

View reviewed changes

seov-nordic force-pushed the npm1304-sample-support branch 2 times, most recently from 40a14fc to fe01278 Compare August 19, 2025 08:51

github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Aug 19, 2025

seov-nordic removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Aug 19, 2025

seov-nordic force-pushed the npm1304-sample-support branch from fe01278 to 824a151 Compare August 19, 2025 10:39

github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Aug 19, 2025

seov-nordic removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Aug 19, 2025

seov-nordic added this to the 3.1.1 milestone Aug 20, 2025

seov-nordic added the backport v3.1-branch label Aug 20, 2025

seov-nordic force-pushed the npm1304-sample-support branch from 824a151 to 3ba70b3 Compare August 20, 2025 12:42

github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Aug 20, 2025

samples: pmic: update npm1300_fuel_gauge sample to support nPM1304

486ccec

Added possibility to choose the nPM1300 or the nPM1304 EK shield to build for. Adapted code and DTS overlays to accomodate both PMICs. Signed-off-by: Sergei Ovchinnikov <[email protected]>

seov-nordic force-pushed the npm1304-sample-support branch from 3ba70b3 to 486ccec Compare August 20, 2025 12:47

seov-nordic removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Aug 20, 2025

nordicjm approved these changes Aug 20, 2025

View reviewed changes

rlubos merged commit f1fd516 into nrfconnect:main Aug 20, 2025
20 of 21 checks passed

NordicBuilder mentioned this pull request Aug 20, 2025

[Backport v3.1-branch] samples: pmic: update npm1300_fuel_gauge sample to support nPM1304 #24079

Merged

samples: pmic: update npm1300_fuel_gauge sample to support nPM1304 #23437

samples: pmic: update npm1300_fuel_gauge sample to support nPM1304 #23437

Conversation

seov-nordic commented Jul 24, 2025

Uh oh!

NordicBuilder commented Jul 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CI Information

Inputs:

Sources:

Github labels

Outputs:

Toolchain

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

Uh oh!

github-actions bot commented Jul 24, 2025

Uh oh!

github-actions bot commented Jul 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

seov-nordic commented Jul 30, 2025

Uh oh!

peknis commented Jul 30, 2025

Uh oh!

seov-nordic commented Jul 31, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

divipillai commented Aug 7, 2025

Uh oh!

seov-nordic commented Aug 19, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

NordicBuilder commented Jul 24, 2025 •

edited

Loading

github-actions bot commented Jul 24, 2025 •

edited

Loading